Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Accept None in connect() and improve migration dialogue #947

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jan 17, 2025

Addresses:

Also improves the migration dialogue when instance version and package version mismatch.

@falexwolf falexwolf changed the title 🚸 Accept None in connect() 🚸 Accept None in connect() and improve migration dialogue Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.91%. Comparing base (d1969b1) to head (c107689).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lamindb_setup/_connect_instance.py 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
+ Coverage   83.75%   83.91%   +0.15%     
==========================================
  Files          43       43              
  Lines        3472     3469       -3     
==========================================
+ Hits         2908     2911       +3     
+ Misses        564      558       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request January 17, 2025 06:52 Inactive
@falexwolf falexwolf merged commit 04fe679 into main Jan 17, 2025
13 checks passed
@falexwolf falexwolf deleted the acceptnone branch January 17, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant