🎨 Introduce ordered collections and simplify .mapped()
#1390
Conversation
|
I don't think removing "auto" is necessary, it is easier to check with "auto" first then to manually check variables. Also it is important to avoid any join if the variables are exactly the same for performance reasons. |
|
I believe removing join_vars="auto" doesn't simplify anything, just requires a user to do additional actions manually instead. |
|
Pasting our discussion for reference: https://laminlabs.slack.com/archives/C03Q5TXF797/p1704653536322439?thread_ts=1704228794.520039&cid=C03Q5TXF797 |
falexwolf
changed the title
.mapped()
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
- Coverage 92.85% 92.60% -0.26%
==========================================
Files 44 44
Lines 4284 4311 +27
==========================================
+ Hits 3978 3992 +14
- Misses 306 319 +13 ☔ View full report in Codecov by Sentry. |
| assert ls_ds.join_vars == "outer" | ||
| assert len(ls_ds.var_joint) == 6 | ||
| assert len(ls_ds[0]) == 2 | ||
| assert len(ls_ds[0][0]) == 6 | ||
| assert np.array_equal(ls_ds[1][0], np.array([4, 5, 8, 0, 0, 0])) | ||
| print(ls_ds[0][0]) |
There was a problem hiding this comment.
Are those print statements a relict from making the tests work?
There was a problem hiding this comment.
Yes, and a slight worry that this output might be helpful in the future again. It took me a while to understand the test, and so I thought I'd leave these statements there for a little longer.
https://laminlabs.slack.com/archives/C03Q5TXF797/p1704653576465039?thread_ts=1704228794.520039&cid=C03Q5TXF797