-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add unknown_label and use dict for output in Collection.mapped #1443
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
=======================================
Coverage 92.55% 92.56%
=======================================
Files 44 44
Lines 4395 4439 +44
=======================================
+ Hits 4068 4109 +41
- Misses 327 330 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename "get_label_weights" to "get_label_freqs" or something. Because the weight one would want might often not be "1/count" this seems too much for most applications..
But i think calling this frequencies is more misleading. |
Subj. Also allows to select label keys for encoding.