Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add unknown_label and use dict for output in Collection.mapped #1443

Closed
wants to merge 6 commits into from

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Feb 19, 2024

Subj. Also allows to select label keys for encoding.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6b6b941) 92.55% compared to head (5153717) 92.56%.
Report is 22 commits behind head on main.

Files Patch % Lines
lamindb/dev/_mapped_collection.py 96.96% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1443   +/-   ##
=======================================
  Coverage   92.55%   92.56%           
=======================================
  Files          44       44           
  Lines        4395     4439   +44     
=======================================
+ Hits         4068     4109   +41     
- Misses        327      330    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 19, 2024

@github-actions github-actions bot temporarily deployed to pull request February 19, 2024 16:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 19, 2024 18:03 Inactive
Copy link

@jkobject jkobject left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename "get_label_weights" to "get_label_freqs" or something. Because the weight one would want might often not be "1/count" this seems too much for most applications..

@Koncopd
Copy link
Member Author

Koncopd commented Feb 27, 2024

#1460

@Koncopd
Copy link
Member Author

Koncopd commented Feb 27, 2024

But i think calling this frequencies is more misleading.

@Koncopd Koncopd deleted the mapped_features branch September 18, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants