✨ Add .obsm and .layers to MappedCollection
#1562
Conversation
Koncopd
force-pushed
the
mapped_add_keys
branch
3 times, most recently
from
dddac74
to
1912feb
Compare
Koncopd
force-pushed
the
mapped_add_keys
branch
from
1912feb
to
918e9f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
+ Coverage 89.97% 90.00% +0.03%
==========================================
Files 50 50
Lines 5227 5253 +26
==========================================
+ Hits 4703 4728 +25
- Misses 524 525 +1 ☔ View full report in Codecov by Sentry. |
| @@ -209,7 +209,9 @@ def from_artifacts(artifacts: Iterable[Artifact]) -> tuple[str, dict[str, str]]: | |||
| # docstring handled through attach_func_to_class_method | |||
| def mapped( | |||
| self, | |||
| label_keys: str | list[str] | None = None, | |||
| layers_keys: str | list[str] | None = None, | |||
| obs_keys: str | list[str] | None = None, | |||
There was a problem hiding this comment.
I wouldn't make this change without first deprecating label_keys, Sergei. It's going to break people's code. I mean, you could simply add one line of logic that feeds label_keys into obs_keys and prints a warning, and thing things wouldn't break.
There was a problem hiding this comment.
I am not sure it makes a difference taking into account all other changes like key names changes in __getitem__.
There was a problem hiding this comment.
It's alright, I'll make a clear note in the changelog! I'm merging!
falexwolf
changed the title
.obsm and .layers to MappedCollection
Also laminlabs/lnschema-core#367