Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 ln.Folder becomes ln.Tag & directories now modeled as prefixes (as on S3) #794

Merged
merged 20 commits into from
Jun 22, 2023

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jun 21, 2023

@falexwolf falexwolf changed the title 🎨 Repurpose Folder as Tag 🚸 ln.Folder becomes ln.Tag and directories are managed as on S3 Jun 22, 2023
@falexwolf falexwolf changed the title 🚸 ln.Folder becomes ln.Tag and directories are managed as on S3 🚸 ln.Folder becomes ln.Tag & directories now managed as on S3 Jun 22, 2023
@falexwolf falexwolf changed the title 🚸 ln.Folder becomes ln.Tag & directories now managed as on S3 🚸 ln.Folder becomes ln.Tag & directories now modeled as prefixes (as on S3) Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #794 (3ead710) into main (0e1fbb4) will decrease coverage by 0.61%.
The diff coverage is 93.97%.

❗ Current head 3ead710 differs from pull request most recent head 2b60b36. Consider uploading reports for the commit 2b60b36 to get more accurate results

@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   78.52%   77.92%   -0.61%     
==========================================
  Files          33       31       -2     
  Lines        1779     1712      -67     
==========================================
- Hits         1397     1334      -63     
+ Misses        382      378       -4     
Impacted Files Coverage Δ
lamindb/__init__.py 100.00% <ø> (ø)
lamindb/_file_access.py 70.83% <75.00%> (-1.59%) ⬇️
lamindb/_file_methods.py 90.76% <93.47%> (+0.44%) ⬆️
lamindb/_baseorm_methods.py 75.67% <100.00%> (+1.60%) ⬆️
lamindb/_file.py 91.89% <100.00%> (+0.75%) ⬆️
lamindb/dev/storage/_backed_access.py 76.09% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 09:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 09:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 10:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 10:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 11:09 Inactive
@falexwolf falexwolf merged commit d12e753 into main Jun 22, 2023
@falexwolf falexwolf deleted the tag1 branch June 22, 2023 11:21
@github-actions github-actions bot temporarily deployed to pull request June 22, 2023 11:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant