Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add relationship between DFolder and DObject #110

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

bpenteado
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 16, 2023

@github-actions github-actions bot temporarily deployed to pull request February 16, 2023 14:56 Inactive
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #110 (9f30f70) into main (407b262) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   87.24%   87.30%   +0.06%     
==========================================
  Files          14       14              
  Lines         392      394       +2     
==========================================
+ Hits          342      344       +2     
  Misses         50       50              
Impacted Files Coverage Δ
lnschema_core/_core.py 91.11% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lnschema_core/_core.py Outdated Show resolved Hide resolved
lnschema_core/_core.py Outdated Show resolved Hide resolved
Copy link
Member

@falexwolf falexwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Please just rename to dfolders in DObject from folders.

And the other two tiny cosmetic remarks about typing strings.

@github-actions github-actions bot temporarily deployed to pull request February 16, 2023 16:35 Inactive
@bpenteado bpenteado merged commit e7d3cd5 into main Feb 16, 2023
@bpenteado bpenteado deleted the dfolder-relationship branch February 16, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants