Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Better names, more relationships directly on File #157

Merged
merged 31 commits into from
Apr 16, 2023
Merged

🚚 Better names, more relationships directly on File #157

merged 31 commits into from
Apr 16, 2023

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Apr 16, 2023

  • 🚚 Rename File.source to File.run (and File.source_id to File.run_id) and make optional
  • 🚚 Rename created_by to created_by_id everywhere, add created_by_id to File and Storage
  • 🚸 Add created_by back as relationship with type User
  • 🚚 Add transform_id to File, and transform as a relationship
  • 🚚 Rename File.targets to File.input_of
  • 🚚 Rename Transform.v to Transform.version

@falexwolf falexwolf changed the title Run 🚚 Rename File.source to File.run Apr 16, 2023
@falexwolf falexwolf changed the title 🚚 Rename File.source to File.run 🚚 Better names, more relationships directly on File Apr 16, 2023
@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request April 16, 2023 15:29 Inactive
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #157 (b8bcf42) into main (43ec39a) will decrease coverage by 0.07%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   69.65%   69.58%   -0.07%     
==========================================
  Files          14       14              
  Lines         547      559      +12     
==========================================
+ Hits          381      389       +8     
- Misses        166      170       +4     
Impacted Files Coverage Δ
lnschema_core/_core.py 60.58% <80.64%> (+1.42%) ⬆️
lnschema_core/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant