Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Schema modules on SQL level #49

Merged
merged 14 commits into from
Nov 1, 2022
Merged

✨ Schema modules on SQL level #49

merged 14 commits into from
Nov 1, 2022

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Oct 31, 2022

Actually accomplish

Went via __table_args__ as it seemed that metadata objects created for one schema module weren't aware of tables in other schema modules.

This leads to the not-so-elegant necessity to manually add the schema name to tables that modify __table_args__ at model definition: #50

@falexwolf falexwolf changed the title ✨ Module on SQL level ✨ Schema modules on SQL level Oct 31, 2022
@falexwolf falexwolf changed the title ✨ Schema modules on SQL level ✨ Schema modules on SQL level Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

@github-actions github-actions bot temporarily deployed to pull request November 1, 2022 15:29 Inactive
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #49 (94539d5) into main (a8c67c5) will decrease coverage by 0.88%.
The diff coverage is 91.80%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   91.66%   90.78%   -0.89%     
==========================================
  Files           8       11       +3     
  Lines         180      217      +37     
==========================================
+ Hits          165      197      +32     
- Misses         15       20       +5     
Impacted Files Coverage Δ
lnschema_core/dev/_id.py 62.50% <ø> (ø)
lnschema_core/dev/_type.py 100.00% <ø> (ø)
lnschema_core/dev/id.py 100.00% <ø> (ø)
lnschema_core/dev/type.py 100.00% <ø> (ø)
lnschema_core/dev/sqlmodel.py 80.00% <80.00%> (ø)
lnschema_core/__init__.py 100.00% <100.00%> (ø)
lnschema_core/_core.py 100.00% <100.00%> (ø)
lnschema_core/_users.py 100.00% <100.00%> (ø)
lnschema_core/dev/__init__.py 100.00% <100.00%> (ø)
lnschema_core/dev/_versions.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request November 1, 2022 16:04 Inactive
@falexwolf falexwolf merged commit c77918b into main Nov 1, 2022
@falexwolf falexwolf deleted the naming branch November 1, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant