Skip to content
This repository has been archived by the owner on Jan 2, 2025. It is now read-only.

✨ Bypass load settings #65

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

fredericenard
Copy link
Contributor

No description provided.

@fredericenard fredericenard changed the title Bypass load settings ✨ Bypass load settings Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

@github-actions github-actions bot temporarily deployed to pull request December 2, 2022 06:16 Inactive
@fredericenard fredericenard merged commit 8ceba5d into main Dec 2, 2022
@fredericenard fredericenard deleted the bypass-load-settings-for-hub-initialization branch December 2, 2022 06:17
@falexwolf
Copy link
Member

Nice! Good solution!

One thing I'm thinking is that'd be good to start documenting the environment variables that the packages use.

We have about 10 across several packages, and they're all implicit and not-documented.

Maybe in the devops repo? Not urgent, of course.

@fredericenard
Copy link
Contributor Author

Yes totally agreed! I also have to put all of them in capitalized letters, i did a mistake by not applying this convention systematically..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants