Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add rich string representation for ORM classes #95

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

bpenteado
Copy link
Contributor

For discussion: new instance representation is also applied inside of lists. Do we want that?

@github-actions
Copy link

github-actions bot commented Jan 30, 2023

@github-actions github-actions bot temporarily deployed to pull request January 30, 2023 18:40 Inactive
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #95 (908a565) into main (5aab829) will decrease coverage by 2.28%.
The diff coverage is 45.45%.

❗ Current head 908a565 differs from pull request most recent head eac79e1. Consider uploading reports for the commit eac79e1 to get more accurate results

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   87.10%   84.82%   -2.28%     
==========================================
  Files          14       14              
  Lines         380      402      +22     
==========================================
+ Hits          331      341      +10     
- Misses         49       61      +12     
Impacted Files Coverage Δ
lnschema_core/dev/sqlmodel.py 81.64% <45.45%> (-5.86%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@falexwolf falexwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Up to small cosmetics as just discussed!

Please feel free to merge and make a release to bring it into LaminDB!

@github-actions github-actions bot temporarily deployed to pull request January 31, 2023 16:36 Inactive
@bpenteado bpenteado merged commit 7941ada into main Jan 31, 2023
@bpenteado bpenteado deleted the rich-string-orm branch January 31, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants