Fix variance checking in refinements #18053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do variance checks for parameters in method types and poly types of refinements. Fixes scala#18035
mbovel
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
If I understood well: as the source comment states, we do not check parameters of methods because these are checked later. However, this only applies to the first level. Parameters within methods in refinement types, for example, still require checking. Therefore, this PR removes the MethodOrPoly case from the VarianceChecker, allowing the transformer to recurse on parameters. The special case for first-level definitions is moved to a new function, checkInfo. This new function still needs to be recursive in order to appropriately handle polymorphic and curried functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do variance checks for parameters in method types and poly types of refinements.
Fixes #18035