Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variance checking in refinements #18053

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix variance checking in refinements #18053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions compiler/src/dotty/tools/dotc/typer/VarianceChecker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ class VarianceChecker(using Context) {
case TypeAlias(alias) => this(status, alias)
case _ => foldOver(status, tp)
}
case tp: MethodOrPoly =>
this(status, tp.resultType) // params will be checked in their TypeDef or ValDef nodes.
case AnnotatedType(_, annot) if annot.symbol == defn.UncheckedVarianceAnnot =>
status
case tp: ClassInfo =>
Expand All @@ -144,10 +142,16 @@ class VarianceChecker(using Context) {
}
}

def checkInfo(info: Type): Option[VarianceError] = info match
case info: MethodOrPoly =>
checkInfo(info.resultType) // params will be checked in their TypeDef or ValDef nodes.
case _ =>
apply(None, info)

def validateDefinition(base: Symbol): Option[VarianceError] = {
val saved = this.base
this.base = base
try apply(None, base.info)
try checkInfo(base.info)
finally this.base = saved
}
}
Expand Down
15 changes: 15 additions & 0 deletions tests/neg/i18035.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import reflect.Selectable.reflectiveSelectable

class A[+Cov](f: Cov => Unit) {
def foo: { def apply(c: Cov): Unit } = // error
f
}

val aForString = new A[String](_.length)
// => val aForString: A[String]

val aForStringIsAForAny: A[Any] = aForString
// => val aForStringIsAForAny: A[Any]

val _ = aForStringIsAForAny.foo(123)
// => java.lang.ClassCastException: class java.lang.Integer cannot be cast to class java.lang.String (java.lang.Integer and java.lang.String are in module java.base of loader 'bootstrap')