Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Incorrect semanticdb span on Selectable #18576

Merged
merged 1 commit into from
Sep 21, 2023
Merged

bugfix: Incorrect semanticdb span on Selectable #18576

merged 1 commit into from
Sep 21, 2023

Conversation

jkciesluk
Copy link
Contributor

Semanticdb range on selectDynamic in foo.bar previously contained .bar instead of bar

Connected to scalameta/metals#5621
Also closes #16771 by porting scalameta/metals#4907

@jkciesluk
bugfix: Incorrect semanticdb span on Selectable
5df5855 
Semanticdb range on selectDynamic in `foo.bar` previously contained `.bar` instead of `bar`
bishabosha
bishabosha approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@bishabosha bishabosha added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Sep 21, 2023
@bishabosha bishabosha merged commit cc40aca into scala:main Sep 21, 2023
17 checks passed
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "bugfix: Incorrect semanticdb span on Selectable" to LTS (#2…
63ba0f0 
…0618)

Backports #18576 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Jun 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "bugfix: Incorrect semanticdb span on Selectable" to LTS (#2…
09f4c79 
…0676)

Backports #18576 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
area:semanticdb
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Wrong nameSpan in Select when using parentheses
3 participants
@jkciesluk @bishabosha @Kordyjan