Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure selectableDynamic is not show when structural types #5621

Open
tgodzik opened this issue Sep 6, 2023 · 1 comment
Open

Make sure selectableDynamic is not show when structural types #5621

tgodzik opened this issue Sep 6, 2023 · 1 comment
Assignees
@jkciesluk
Labels
bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3 semantic-highlight semanticdb Related to semanticdb usage in Metals upstream-fix-needed Waiting on a fix upstream

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Sep 6, 2023

Describe the bug

Related to the StructuralTypes changes in https://github.com/scalameta/metals/pull/5620/files

We should probably make sure that we don't point to selectableDynamic in those cases

Expected behavior

Go to definition and semanticdb properly show the actual values being used

Operating system

Linux

Editor/Extension

VS Code

Version of Metals

v1.0.1

Extra context or search terms

selectable dynamic semanticdb
@tgodzik tgodzik added bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3 semanticdb Related to semanticdb usage in Metals upstream-fix-needed Waiting on a fix upstream semantic-highlight labels Sep 6, 2023
@tgodzik tgodzik mentioned this issue Sep 6, 2023
Merged
@tgodzik
Copy link
Contributor Author

tgodzik commented Sep 6, 2023

We could possibly show both selectDynamic and the actual method like with objects and apply methods

@jkciesluk jkciesluk self-assigned this Sep 19, 2023
@jkciesluk jkciesluk mentioned this issue Sep 21, 2023
Merged
bishabosha added a commit to scala/scala3 that referenced this issue Sep 21, 2023
@bishabosha
bugfix: Incorrect semanticdb span on Selectable (#18576)
cc40aca 
Semanticdb range on selectDynamic in `foo.bar` previously contained
`.bar` instead of `bar`

Connected to scalameta/metals#5621
Also closes #16771 by porting
scalameta/metals#4907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkciesluk jkciesluk

Labels
bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3 semantic-highlight semanticdb Related to semanticdb usage in Metals upstream-fix-needed Waiting on a fix upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgodzik @jkciesluk