Async primitives #85
Async primitives #85
Conversation
| * @param value | ||
| * the grant counter | ||
| */ | ||
| class Semaphore private (private var value: AtomicInteger) extends Async.Source[Unit]: |
There was a problem hiding this comment.
If we want this to be a Source I think it's better to make it a source with a release value (a Source[SemGuard] with a .release method?) or maybe a Resource[Unit]?
There was a problem hiding this comment.
I don't really want it to be a Source. But that's the only thing one can await, so I do need a Source implementation somehow. I could add it as hidden inner object or make Semaphore a trait and have the hidden implementation implement the Source, but both add (allocation/method lookup) overhead.
The SemGuard idea looks nice, but then I would want the Semaphore again to implement it as well, just returning this from the Source.
Using a Semaphore as a Resource is a good idea, but maybe not as the default interface.. ?
m8nmueller
force-pushed
the
async-resource
branch
from
fe2dc98
to
a8ef9e5
Compare
m8nmueller
force-pushed
the
async-resource
branch
from
a8ef9e5
to
f4143ea
Compare
|
I squashed the commits now without changing the overall code diff before/after. The tests failure we just had showed a minor mistake in the test conception. I hate using platform locks on gears futures. Should all be solved now. Merge as you are :) |
This PR contains primitives for synchronization and concurrency management:
Resourceto wrap allocation/cleanup of (currently mostly computation) resources in different layers of safetySemaphore, because it's usefulAdditionally, the specification of
Async.awaitin light of locking Sources, that care about there result being used (like Semaphores which the consumer might want to reset on cancellation), was clarified and implemented. Now, cancellation will be ignored if it happens after a listener lock acquire that leads to completion. Still, cancellation can be requested synchronously without waiting.