Port scala#4737 and scala#4944 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
|
Testing this in scala/scala3#3391 |
|
Passed tests in scala/scala3#3391 |
10 tasks
nicolasstucki
changed the title
smarter
reviewed
Oct 26, 2017
| @@ -0,0 +1,70 @@ | |||
| package scala.tools.nsc | |||
There was a problem hiding this comment.
It'd be nice to copy this test to dotty.
There was a problem hiding this comment.
Ported in scala/scala3#3391
smarter
reviewed
Oct 26, 2017
| @@ -0,0 +1,907 @@ | |||
| /* NSC -- new Scala compiler | |||
There was a problem hiding this comment.
No need to get this class in since we don't use optimizations, don't you think?
|
When porting commits, please put a link to the original PR and put the hash of the original commit in the commit message. |
nicolasstucki
force-pushed
the
port-4737
branch
from
3b213b2 to
e9a9a43
Compare
... instead of scala.collection.mutable.StringBuilder to benefit from JVM optimizations. Unfortunately primitives are already boxed in erasure when they end up in this part of the backend. Port of cd0211c
|
Passed tests in scala/scala3#3391 |
smarter
approved these changes
Oct 27, 2017
nicolasstucki
pushed a commit
to dotty-staging/scala
that referenced
this pull request
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port: