generated from martinthomson/internet-draft-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address John's comment, editorial, alignment with ML-KEM I-D #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially deals with #12; didn't incorporate the refs to PKCS#10, CMP, CMC, etc. Some alignment with ML-KEM I-D. Editorial suggestions; added a lot of newlines because in codeview it was much easier to read without always have to scroll right.
seanturner
commented
Jul 9, 2024
seanturner
commented
Jul 9, 2024
seanturner
commented
Jul 9, 2024
seanturner
commented
Jul 9, 2024
seanturner
commented
Jul 9, 2024
Freudian slip
seanturner
commented
Jul 9, 2024
I hate XML - it only took me 7 times to get this to work. |
Merged
@jakemas @csosto-pk @bwesterb PTAL my plan would be to land this over the weekend so we upload a new I-D version to talk about at the LAMPS@IETF120 session. |
Perfect, thanks Sean! I’ll take a look now and merge.
From: Sean Turner ***@***.***>
Reply-To: lamps-wg/dilithium-certificates ***@***.***>
Date: Thursday, July 18, 2024 at 12:02 PM
To: lamps-wg/dilithium-certificates ***@***.***>
Cc: "Massimo, Jake" ***@***.***>, Mention ***@***.***>
Subject: Re: [lamps-wg/dilithium-certificates] Address John's comment, editorial, alignment with ML-KEM I-D (PR #14)
@jakemas<https://github.com/jakemas> @csosto-pk<https://github.com/csosto-pk> @bwesterb<https://github.com/bwesterb> PTAL my plan would be to land this over the weekend so we upload a new I-D version to talk about at the ***@***.*** session.
—
Reply to this email directly, view it on GitHub<#14 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQHHONEFBXVFFV3EKMTELF3ZNAGJRAVCNFSM6AAAAABKSWLBUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXGMZTIMBTGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially deals with #12; didn't incorporate the refs to PKCS#10, CMP, CMC, etc.
Some alignment with ML-KEM I-D.
Editorial suggestions; added a lot of newlines because in codeview it was much easier to read without always have to scroll right.