Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing CompositeKEMParams #4

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Removing CompositeKEMParams #4

merged 5 commits into from
Oct 3, 2023

Conversation

ounsworth
Copy link
Contributor

No description provided.

@ounsworth ounsworth mentioned this pull request Oct 2, 2023
Closed
johngray-dev
johngray-dev approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@johngray-dev johngray-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Other than needing to define the ASN.1 module OID:
id-mod-composite-kems

I was able to compile the ASN.1, so that is great!

@ounsworth
Copy link
Contributor Author

Looks good! Other than needing to define the ASN.1 module OID: id-mod-composite-kems

I was able to compile the ASN.1, so that is great!

Yeah, I replace the TBDMOD with 999 when I'm test-compiling, but I've gotta leave something that's easy for IANA to CTRL+F replace.

@ounsworth ounsworth merged commit 1fb6913 into main Oct 3, 2023
@ounsworth ounsworth deleted the mike_asn1_remove_params branch October 3, 2023 14:22
@ounsworth ounsworth mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngray-dev johngray-dev johngray-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ounsworth @johngray-dev