Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Kris comments about Section B.1 on FIPS #145 #2

Closed
johngray-dev opened this issue Jun 4, 2024 · 1 comment
Closed

Address Kris comments about Section B.1 on FIPS #145 #2

johngray-dev opened this issue Jun 4, 2024 · 1 comment

Comments

@johngray-dev
Copy link
Collaborator

johngray-dev commented Jun 4, 2024

From: EntrustCorporation/draft-ounsworth-composite-sigs#145

Address Kris's comments:

ZjQcmQRYFpfptBannerEnd
In the section "B.1 FIPS certification", the draft says:

"algorithm to be [...] considered FIPS-approved even when one of the component algorithms is not"
and then
"overall composite should be considered full strength and thus FIPS-approved"
I think, the "full strength" may be misleading. Also the term is not clearly defined. Hence, it could be understood as "full strength of classical+PQ" and that is opposite to what NIST FAQ [1] says. I.e. let say MLDSA is FIPS-approved in a future, and we create composite with MLDSA-44 + some on-ramp signature that claims level 5. Does it mean the strength of that construct should be considered FIPS-approved with security strength of equal to level 2 or 5?

As this draft is now about creating composite signatures with MLDSA, so do we need B.1? The discussion about FIPS-approved dual signature schemes sounds like a great discussion to have, but in a different place (and ideally on CMUF forum).

My suggestion would be to remove B.1 to avoid spreading potentially misleading information about important topic.

Additional nit:

The abstract says "Composite algorithms are provided which combine ML-DSA with RSA, ECDSA, Ed25519, and Ed448.". Shouldn't it say MLDSA only?

Kris Kwiatkowski
Cryptography Dev

--- Group discussed this and decide to change the following:

change:
overall composite should be considered full strength and thus FIPS-approved"
to
overall composite should be considered at least as strong and thus FIPS-approved"

until FIPS deprecates RSA or EC...

johngray-dev added a commit that referenced this issue Jun 6, 2024
- Added changes since adoption section
- Resolved issue #2 and verified #3 is resolved
@johngray-dev johngray-dev mentioned this issue Jun 6, 2024
johngray-dev added a commit that referenced this issue Jun 6, 2024
Update tov13, fix issues #2 and #3
@johngray-dev
Copy link
Collaborator Author

The comment was addressed and the issue has been resolved is -01 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant