-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ESX(i) 7.0.3 #249
Conversation
Thanks for accepting. Would you be so kind to add "hacktoberfest" as a topic to the project for the rest of October? |
@lamw I just realized the LAST_MODIFIED_DATE constant was not changed for the 2021_10_20 release |
@p-schneider Can you file a quick issue and that way someone can take it? |
PR created at #250 (or did you mean issue like in "Issues" != "Pull Requests"?) |
Hi William,
while you are at it, could you please remove the **hacktoberfest-accepted** from
the commit message (unless you don't mind it being there) and add a label or a
topic as shown in the two tweets I retweeted to you?
That would be awesome,
Patrick
--
punkt.de GmbH
Patrick M. Hausen
.infrastructure
Kaiserallee 13a
76133 Karlsruhe
Tel. +49 721 9109500
https://infrastructure.punkt.de
***@***.***
AG Mannheim 108285
Geschäftsführer: Jürgen Egeling, Daniel Lienert, Fabian Stein
|
@p-schneider Yea, typically (I only recently learned about this while working on another OSS project) that you'd normally file an I'll review shortly and rebuild the deliverables, thanks again! |
You mean from the PR title? Its not in the commit message since that's something that happens on your end when you create the PR |
Hi!
Am 21.10.2021 um 18:13 schrieb William Lam ***@***.***>:
You mean from the PR title? Its not in the commit message since that's something that happens on your end when you create the PR
Ah, I see. In that case do as you please. But my contribution still does not
count. See for example the OPNsense project at:
https://github.com/opnsense/core
In the upper right you find a "topic" cloud - that's where the "hacktoberfest" needs
to be. Or the "**hacktoberfest-approved**" as a label of the single pull-request.
The topics are in the project settings, don't know about the label, so I sent you
tweets by two friends of mine that I hoped would explain things.
Kind regards,
Patrick
--
punkt.de GmbH
Patrick M. Hausen
.infrastructure
Kaiserallee 13a
76133 Karlsruhe
Tel. +49 721 9109500
https://infrastructure.punkt.de
***@***.***
AG Mannheim 108285
Geschäftsführer: Jürgen Egeling, Daniel Lienert, Fabian Stein
|
Sorry, I don't see what you're referring to. Might be best to ask folks on explicitly what is needed to qualify |
No description provided.