-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply assorted ruff rules #59
Open
DimitriPapadopoulos
wants to merge
20
commits into
lamyj:master
Choose a base branch
from
DimitriPapadopoulos:ruff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
September 23, 2024 07:08
45b09ff
to
7c9afb1
Compare
F401 imported but unused
F841 Local variable is assigned to but never used
UP010 Unnecessary `__future__` import `print_function` for target Python version
UP025 Remove unicode literals from strings
UP030 Use implicit references for positional format fields
UP031 Use format specifiers instead of percent format
UP032 Use f-string instead of `format` call
PERF401 Use a list comprehension to create a transformed list
B904 Within an `except` clause, raise exceptions with `raise ... from err` or `raise ... from None` to distinguish them from errors in exception handling
SIM114 Combine `if` branches using logical `or` operator
SIM118 Use `key in dict` instead of `key in dict.keys()`
C416 Unnecessary `list` comprehension (rewrite using `list()`)
C419 Unnecessary list comprehension
PIE808 Unnecessary `start` argument in `range`
PIE810 Call `endswith` once with a `tuple`
Q000 Single quotes found but double quotes preferred
RSE102 Unnecessary parentheses on raised exception
PLR5501 Use `elif` instead of `else` then `if`, to reduce indentation
NPY201 `np.NZERO` will be removed in NumPy 2.0. Use `-0.0` instead.
RUF019 Unnecessary key check before dictionary access
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
September 23, 2024 07:15
7c9afb1
to
30556ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.