refactor: convert DataBlock to an enum, add conversion from arrow, normalize dictionaries#2789
Merged
westonpace merged 4 commits intolance-format:mainfrom Aug 28, 2024
Conversation
Member
Author
|
|
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
449fed9 to
1b23713
Compare
dc9bdd4 to
8918ada
Compare
gagan-bhullar-tech
pushed a commit
to gagan-bhullar-tech/lance
that referenced
this pull request
Sep 13, 2024
…rmalize dictionaries (lance-format#2789) a lot of the logic in the conversion from arrow to data block is spread throughout the encoders (the next PR will remove this code from the encoders and change the encoders to use data block)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a lot of the logic in the conversion from arrow to data block is spread throughout the encoders (the next PR will remove this code from the encoders and change the encoders to use data block)