Skip to content

refactor: convert DataBlock to an enum, add conversion from arrow, normalize dictionaries#2789

Merged
westonpace merged 4 commits intolance-format:mainfrom
westonpace:refactor/data-block-to-enum-add-import
Aug 28, 2024
Merged

refactor: convert DataBlock to an enum, add conversion from arrow, normalize dictionaries#2789
westonpace merged 4 commits intolance-format:mainfrom
westonpace:refactor/data-block-to-enum-add-import

Conversation

@westonpace
Copy link
Member

@westonpace westonpace commented Aug 26, 2024

a lot of the logic in the conversion from arrow to data block is spread throughout the encoders (the next PR will remove this code from the encoders and change the encoders to use data block)

@westonpace
Copy link
Member Author

westonpace commented Aug 26, 2024

Leaving in draft until #2784 merges

@github-actions
Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 71.53946% with 220 lines in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (f9f151d) to head (8918ada).

Files Patch % Lines
rust/lance-encoding/src/data.rs 73.72% 173 Missing and 2 partials ⚠️
rust/lance-encoding/src/testing.rs 13.33% 13 Missing ⚠️
...ance-encoding/src/encodings/physical/dictionary.rs 69.44% 8 Missing and 3 partials ⚠️
rust/lance-encoding/src/encodings/physical/fsst.rs 0.00% 9 Missing ⚠️
rust/lance-encoding/src/encodings/physical.rs 20.00% 4 Missing ⚠️
...coding/src/encodings/physical/fixed_size_binary.rs 0.00% 3 Missing ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 87.50% 0 Missing and 2 partials ⚠️
...ust/lance-encoding/src/encodings/physical/basic.rs 80.00% 0 Missing and 1 partial ⚠️
...st/lance-encoding/src/encodings/physical/binary.rs 80.00% 0 Missing and 1 partial ⚠️
...encoding/src/encodings/physical/fixed_size_list.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2789      +/-   ##
==========================================
+ Coverage   78.52%   78.53%   +0.01%     
==========================================
  Files         228      228              
  Lines       68641    69273     +632     
  Branches    68641    69273     +632     
==========================================
+ Hits        53902    54406     +504     
- Misses      11679    11789     +110     
- Partials     3060     3078      +18     
Flag Coverage Δ
unittests 78.53% <71.53%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace force-pushed the refactor/data-block-to-enum-add-import branch from 449fed9 to 1b23713 Compare August 26, 2024 22:34
@westonpace westonpace marked this pull request as ready for review August 26, 2024 22:35
@westonpace westonpace force-pushed the refactor/data-block-to-enum-add-import branch from dc9bdd4 to 8918ada Compare August 28, 2024 14:35
@westonpace westonpace changed the title refactor: Convert DataBlock to an enum. Add conversion from arrow. Restrict dictionary data block structure refactor: Convert DataBlock to an enum. Add conversion from arrow. Normalize dictionaries. Aug 28, 2024
@westonpace westonpace changed the title refactor: Convert DataBlock to an enum. Add conversion from arrow. Normalize dictionaries. refactor: convert DataBlock to an enum, add conversion from arrow, normalize dictionaries. Aug 28, 2024
@westonpace westonpace changed the title refactor: convert DataBlock to an enum, add conversion from arrow, normalize dictionaries. refactor: convert DataBlock to an enum, add conversion from arrow, normalize dictionaries Aug 28, 2024
Copy link
Contributor

@broccoliSpicy broccoliSpicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@westonpace westonpace merged commit 2f25fc4 into lance-format:main Aug 28, 2024
gagan-bhullar-tech pushed a commit to gagan-bhullar-tech/lance that referenced this pull request Sep 13, 2024
…rmalize dictionaries (lance-format#2789)

a lot of the logic in the conversion from arrow to data block is spread
throughout the encoders (the next PR will remove this code from the
encoders and change the encoders to use data block)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants