chore: add FTS alias for inverted index #5680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
approved these changes
Jan 12, 2026
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
I have a suggestion but we can restore the alias either way.
| "ZONEMAP", | ||
| "LABEL_LIST", | ||
| "INVERTED", | ||
| "FTS", |
Member
There was a problem hiding this comment.
I wonder if it would be easier to just do something like...
if index_type.upper() == "FTS":
index_type = "INVERTED"
At the top of this method. That way, if we add other checks for INVERTED in the future, we won't have to worry about maintaining the FTS alias?
Contributor
Author
There was a problem hiding this comment.
Tried this but that may be confusing if people switch back to rust lib and it doesn't work. intend to make sure both FTS and INVERTED` can work in all places
Xuanwo
approved these changes
Jan 12, 2026
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.