Skip to content

fix: trait Array has been sealed in arrow new version #5690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 1 commit into from
Jan 12, 2026
Merged

fix: trait Array has been sealed in arrow new version #5690

Xuanwo merged 1 commit into from
Jan 12, 2026

Conversation

@Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Jan 12, 2026

Arrow 57.2 has changed Array trait into sealed, this PR provides a workaround.

Parts of this PR were drafted with assistance from Codex (with gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.

@github-actions github-actions bot added bug Something isn't working python labels Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 89.47368% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-arrow/src/bfloat16.rs 80.00% 7 Missing ⚠️
rust/lance-arrow/src/floats.rs 96.55% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Xuanwo Xuanwo merged commit 3566ced into main Jan 12, 2026
26 of 30 checks passed
@Xuanwo Xuanwo deleted the luban/fever-always branch January 12, 2026 10:33
@westonpace westonpace mentioned this pull request Jan 12, 2026
Merged
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
@Xuanwo @jackye1995
fix: trait Array has been sealed in arrow new version (lance-format#5690
de16859 
)

Arrow 57.2 has changed `Array` trait into sealed, this PR provides a
workaround.

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.2`) and fully reviewed and edited by me. I take full
responsibility for all changes.**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BubbleCal BubbleCal BubbleCal approved these changes

Assignees

No one assigned

Labels

bug Something isn't working python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Xuanwo @BubbleCal