Add a hook run after code changes have been applied

[akirak]

Hello, thank you for creating this great package.

I usually use smerge-mode to confirm the hunk suggested via elysium. It would be nice if the mode were turned on after changes have been applied. This elysium-apply-changes-hook will let the user configure such a behaviour.

An example configuration is as follows:

(add-hook 'elysium-apply-changes-hook #'smerge-mode)

[lanceberge]

Thank you for this. Adding this hook looks good, although wouldn't the example you provided toggle smerge-mode on and off with every call to elysium-apply-changes?

It's failing CI - I believe you will need to default the hook to nil

(defcustom elysium-apply-changes-hook nil
  "Hook run after code changes have been applied on a buffer."
  :group 'elysium
  :type 'hook)

[akirak]

It's failing CI - I believe you will need to default the hook to nil

Thank you for pointing this out. I've force-pushed the fix.

the example you provided toggle smerge-mode on and off with every call to elysium-apply-changes

Yes, you are right. It should have been like this:

(add-hook 'elysium-apply-changes-hook #'smerge-start-session)

[lanceberge]

Looks good, thank you