Change error raised for not-implemented feature. Fix test

python/python/lance/sampler.py

@@ -137,7 +137,7 @@ def _filtered_efficient_sample(
  if len(columns) == 1 and filter.lower() == f"{columns[0]} is not null":
  table = pc.drop_null(table)
  elif filter is not None:
- raise Exception(f"Can't yet run filter <{filter}> in-memory")
+ raise NotImplementedError(f"Can't yet run filter <{filter}> in-memory")
  if table.num_rows > 0:
  tables.append(table)
  remaining_rows -= table.num_rows

python/python/tests/torch_tests/test_data.py

@@ -134,14 +134,16 @@ def check(dataset):
  )
  )
 
- # sampling fails
- with pytest.raises(ValueError):
- LanceDataset(
- ds,
- batch_size=10,
- filter="ids >= 300",
- samples=100,
- columns=["ids"],
+ # sampling with filter
+ with pytest.raises(NotImplementedError):
+ check(
+ LanceDataset(
+ ds,
+ batch_size=10,
+ filter="ids >= 300",
+ samples=100,
+ columns=["ids"],
+ )
  )