Address clippy suggestions

lancedb · Jul 26, 2024 · 5a46d47 · 5a46d47
1 parent 0414546
commit 5a46d47
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/rust/lance-encoding/src/data.rs b/rust/lance-encoding/src/data.rs
@@ -44,7 +44,7 @@ impl DataBlockExt for Box<dyn DataBlock> {
  self.as_any_box()
  .downcast::<T>()
  .map_err(|_| Error::Internal {
- message: format!("Couldn't convert to expected layout"),
+ message: "Couldn't convert to expected layout".to_string(),
  location: location!(),
  })
  }
@@ -225,10 +225,10 @@ impl DataBlock for StructDataBlock {
  Ok(unsafe { builder.build_unchecked() })
  }
  } else {
- return Err(Error::Internal {
+ Err(Error::Internal {
  message: format!("Expected Struct, got {:?}", data_type),
  location: location!(),
- });
+ })
  }
  }
 }
diff --git a/rust/lance-encoding/src/encodings/physical/fixed_size_list.rs b/rust/lance-encoding/src/encodings/physical/fixed_size_list.rs
@@ -80,7 +80,7 @@ impl PrimitivePageDecoder for FixedListDecoder {
  let child_data = self.items_decoder.decode(rows_to_skip, num_child_rows)?;
  let mut child_data = child_data.try_into_layout::<FixedWidthDataBlock>()?;
  child_data.num_values = num_rows;
- child_data.bits_per_value = child_data.bits_per_value * self.dimension;
+ child_data.bits_per_value *= self.dimension;
  Ok(child_data)
  }
 }