Skip to content

Commit

Permalink
chore: disable pprof on non-Linux targets (#2523)
Browse files Browse the repository at this point in the history
pprof doesn't work on Windows. It's disabled in most of the Lance
libraries, except for two: lance-index and lance-io. This PR disables it
for those two in the same manner.

See also tikv/pprof-rs#9

Co-authored-by: Lei Xu <lei@lancedb.com>
  • Loading branch information
NickDarvey and eddyxu authored Jun 29, 2024
1 parent 2c7f213 commit f2ca181
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion rust/lance-index/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,16 @@ clap = { workspace = true, features = ["derive"] }
criterion.workspace = true
lance-datagen.workspace = true
lance-testing.workspace = true
pprof.workspace = true
tempfile.workspace = true
datafusion-sql.workspace = true

[build-dependencies]
prost-build.workspace = true
rustc_version.workspace = true

[target.'cfg(target_os = "linux")'.dev-dependencies]
pprof.workspace = true

[[bench]]
name = "find_partitions"
harness = false
Expand Down
4 changes: 3 additions & 1 deletion rust/lance-io/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,15 @@ async-priority-channel = "0.2.0"
[dev-dependencies]
criterion.workspace = true
parquet.workspace = true
pprof.workspace = true
tempfile.workspace = true
mockall.workspace = true

[build-dependencies]
prost-build.workspace = true

[target.'cfg(target_os = "linux")'.dev-dependencies]
pprof.workspace = true

[[bench]]
name = "scheduler"
harness = false
Expand Down

0 comments on commit f2ca181

Please sign in to comment.