-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: schema evolution #1911
docs: schema evolution #1911
Conversation
wjones127
commented
Feb 4, 2024
•
edited
Loading
edited
- Adds a documentation section for schema evolution methods, describing each.
- Consolidates methods for schema evolution in Rust, so they have their own header.
Make sure to answer these questions: #1909 (comment) |
5eafbc4
to
66b6a82
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1911 +/- ##
=======================================
Coverage 79.41% 79.42%
=======================================
Files 223 223
Lines 65082 65082
Branches 65082 65082
=======================================
+ Hits 51686 51689 +3
- Misses 10396 10405 +9
+ Partials 3000 2988 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
table = pa.table({"id": pa.array([1, 2, 3])}) | ||
dataset = lance.write_dataset(table, "ids") | ||
|
||
@lance.batch_udf(checkpoint_file="embedding_checkpoint.sqlite") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sqlite might an interesting choice of extension to an outside observer. If we want these files to be opaque maybe just .bin
?
/// Drop columns from the dataset and return updated dataset. Note that this | ||
/// is a zero-copy operation and column is not physically removed from the | ||
/// dataset. | ||
/// Parameters: | ||
/// - `columns`: the list of column names to drop. | ||
#[deprecated(since = "0.9.12", note = "Please use `drop_columns` instead.")] | ||
pub async fn drop(&mut self, columns: &[&str]) -> Result<()> { | ||
self.drop_columns(columns).await | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been deprecated a while, can we just remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that in a follow up. Will better show up in change notes if I do a dedicated PR.
Co-authored-by: Weston Pace <weston.pace@gmail.com>