Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly encode a list<string> type when all items are empty #2653

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

westonpace
Copy link
Contributor

We probably need to add "encode an empty array" tests for all encoding types.

@github-actions github-actions bot added the bug Something isn't working label Jul 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (7782eb9) to head (276b650).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2653      +/-   ##
==========================================
+ Coverage   79.33%   79.37%   +0.03%     
==========================================
  Files         222      222              
  Lines       64584    64588       +4     
  Branches    64584    64588       +4     
==========================================
+ Hits        51236    51265      +29     
+ Misses      10360    10348      -12     
+ Partials     2988     2975      -13     
Flag Coverage Δ
unittests 79.37% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit aa92730 into lancedb:main Jul 29, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants