feat: support bitpacking for signed types #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2662 +/- ##
==========================================
+ Coverage 79.56% 79.59% +0.03%
==========================================
Files 226 226
Lines 66424 66516 +92
Branches 66424 66516 +92
==========================================
+ Hits 52847 52945 +98
+ Misses 10476 10472 -4
+ Partials 3101 3099 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
westonpace
approved these changes
Aug 1, 2024
| Some(BitpackingBufferEncoder::new(num_bits)) | ||
| Some(BitpackingBufferEncoder::new( | ||
| num_bits, | ||
| !data_type.is_unsigned_integer(), |
There was a problem hiding this comment.
Not a huge deal but we could probably get away with only adding the sign bit if there are actually negative values in the page. For example, a user might use i32 because they think they might need support for negatives someday but then never actually store any negative values.
There was a problem hiding this comment.
Good call. I can add this in a follow-up
albertlockett
force-pushed
the
bitpack_signed
branch
2 times, most recently
from
cb59216
to
288e1fd
Compare
albertlockett
force-pushed
the
bitpack_signed
branch
from
288e1fd
to
35e3862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for bitpacking for signed types Int8, Int16, Int32 and Int64. In this case, we use one extra bit in the encoding for as the sign bit, and when decoding pad using 1 instead of 0 when expanding the bitpacked buffer