feat!: simplify take row api #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
requested review from
westonpace and
wjones127
and removed request for
westonpace
|
Windows failure is not relevant |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
==========================================
- Coverage 79.79% 79.78% -0.01%
==========================================
Files 224 224
Lines 65871 65871
Branches 65871 65871
==========================================
- Hits 52562 52558 -4
- Misses 10228 10232 +4
Partials 3081 3081
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
requested changes
Jul 31, 2024
rust/lance/src/dataset.rs
Outdated
Comment on lines
272
to
276
| impl From<&Schema> for ProjectionRequest { | ||
| fn from(schema: &Schema) -> Self { | ||
| Self::from(schema.clone()) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd rather not have this personally. I don't like the idea of there being a hidden clone in the call. The caller can just do take(row_indices, schema.clone()), and then it's clearer the schema is being cloned there.
Closes #2610 * Supports subschemas in `merge_insert` for updates only * Inserts and deletes left as TODO * Field id `-2` is now reserved as a field "tombstone". These tombstones are fields that are no longer in the schema, usually because those fields are now in a different data file. * Fixed a bug in `Merger` where statistics were reset on each batch.
…rust 1.80 (#2641) Co-authored-by: Will Jones <willjones127@gmail.com> Co-authored-by: Lance Release <lance-dev@lancedb.com> Co-authored-by: rmeng <rob.xu.meng@gmail.com>
westonpace
approved these changes
Jul 31, 2024
wjones127
approved these changes
Jul 31, 2024
|
Thanks for doing this. I like this interface a lot better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
take_rowsandtakeAPIs to allow directly takeSchemaagain.