feat!: distinguishable scalar index types #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2671 +/- ##
==========================================
- Coverage 79.65% 79.64% -0.02%
==========================================
Files 226 226
Lines 66245 66325 +80
Branches 66245 66325 +80
==========================================
+ Hits 52768 52824 +56
- Misses 10382 10398 +16
- Partials 3095 3103 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eddyxu
changed the title
BubbleCal
reviewed
Aug 1, 2024
rust/lance-index/src/lib.rs
Outdated
| @@ -67,7 +67,14 @@ pub trait Index: Send + Sync + DeepSizeOf { | |||
| #[derive(Debug, PartialEq, Eq, Copy, Hash, Clone, DeepSizeOf)] | |||
| pub enum IndexType { | |||
| // Preserve 0-100 for simple indices. | |||
| Scalar = 0, | |||
| Scalar = 0, // BTree | |||
There was a problem hiding this comment.
Can we add BTree and let Scalar still indicate BTree?
That could be more clear
eddyxu
force-pushed
the
lei/scalar_index_debug
branch
from
6fd2f19
to
808300e
Compare
BubbleCal
approved these changes
Aug 2, 2024
eddyxu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
Different scalar index types are shown up differently from
list_indices()