feat: add support for the null data type to v2 #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
+ Coverage 79.56% 79.57% +0.01%
==========================================
Files 226 226
Lines 66424 66544 +120
Branches 66424 66544 +120
==========================================
+ Hits 52847 52954 +107
+ Misses 10476 10472 -4
- Partials 3101 3118 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
reviewed
Aug 5, 2024
Comment on lines
+198
to
+204
| if matches!(arr.data_type(), DataType::Null) { | ||
| // Arrays with the null datatype report 0 as the null count so we | ||
| // need special logic to get the correct null count | ||
| (arr.len() as u32, arr.len() as u32) | ||
| } else { | ||
| (arr.null_count() as u32, arr.len() as u32) | ||
| } |
There was a problem hiding this comment.
If you are interested, I think all the exceptions on null count are described here: https://docs.rs/arrow/latest/arrow/array/trait.Array.html#method.logical_nulls
wjones127
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a tiny bit of extra logic because an array with the null data type will report 0 as its null count.