-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make scalar index training configurable #2686
Conversation
@westonpace looks like |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2686 +/- ##
==========================================
- Coverage 79.61% 79.45% -0.17%
==========================================
Files 226 227 +1
Lines 66516 66920 +404
Branches 66516 66920 +404
==========================================
+ Hits 52955 53168 +213
- Misses 10465 10626 +161
- Partials 3096 3126 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This looks great, just a few minor naming suggestions.
FYI: I filed the original issue because I was doing some testing on a dataset with 1 billion rows and after 90 minutes it still had not created a bitmap index on a boolean column. I just tested with this PR and was able to create a bitmap index in 90 seconds 🎉 |
Done! |
Closes #2661.
This PR adds a
scan_unordered_chunks
method to theTrainingSource
trait and provides basic implementations where required.train_bitmap_index
has been updated to take advantage of this new method. Please advise if any other indexing algorithms do not require sorted columns and I'll update accordingly.