Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slight cleanups to path handling so that the indices builder tool properly supports Windows #2689

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

westonpace
Copy link
Contributor

No description provided.

@github-actions github-actions bot added bug Something isn't working python labels Aug 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (712405e) to head (5f269ff).
Report is 1 commits behind head on main.

Files Patch % Lines
rust/lance-index/src/vector/ivf/shuffler.rs 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2689      +/-   ##
==========================================
- Coverage   79.61%   79.59%   -0.02%     
==========================================
  Files         226      226              
  Lines       66516    66523       +7     
  Branches    66516    66523       +7     
==========================================
- Hits        52955    52948       -7     
- Misses      10465    10471       +6     
- Partials     3096     3104       +8     
Flag Coverage Δ
unittests 79.59% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit 7544611 into lancedb:main Aug 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants