fix: search results are not correct after appending index #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only IVF_HNSW_SQ is with this bug, this bug leads to the appending always builds index over the entire dataset, then we may get wrong results. This fix also means that slow appending would be fixed Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
==========================================
- Coverage 79.50% 79.47% -0.03%
==========================================
Files 226 226
Lines 66655 66554 -101
Branches 66655 66554 -101
==========================================
- Hits 52994 52895 -99
+ Misses 10555 10548 -7
- Partials 3106 3111 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only IVF_HNSW_* is with this bug,
this bug leads to the appending always builds index over the entire dataset, then we may get wrong results.
This fix also means that slow appending would be fixed