Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v2 writer used the wrong value to calculate how many rows were available in array #2704

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

westonpace
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Aug 7, 2024
@westonpace
Copy link
Contributor Author

westonpace commented Aug 7, 2024

Need to add some unit tests for regression before this is merged probably.

Regression test added

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (d1f7d3d) to head (2258c63).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage   79.52%   79.53%           
=======================================
  Files         227      227           
  Lines       66754    66756    +2     
  Branches    66754    66756    +2     
=======================================
+ Hits        53089    53094    +5     
  Misses      10538    10538           
+ Partials     3127     3124    -3     
Flag Coverage Δ
unittests 79.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace force-pushed the fix/max-page-size-wrong-avail branch from da0aa29 to 2258c63 Compare August 8, 2024 16:10
@westonpace westonpace merged commit a7e65f4 into lancedb:main Aug 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants