Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct index type of inverted index #2715

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

BubbleCal
Copy link
Contributor

before we had only Scalar/Vector for IndexType,
now we've added concrete types for it, so let it be Inverted

before we had only Scalar/Vector for `IndexType`,
now we've added concrete types for it, so let it be `Inverted`

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the bug Something isn't working label Aug 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (d1f7d3d) to head (91c373a).
Report is 4 commits behind head on main.

Files Patch % Lines
rust/lance-index/src/scalar/inverted/index.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
- Coverage   79.52%   79.31%   -0.22%     
==========================================
  Files         227      227              
  Lines       66754    66771      +17     
  Branches    66754    66771      +17     
==========================================
- Hits        53089    52962     -127     
- Misses      10538    10709     +171     
+ Partials     3127     3100      -27     
Flag Coverage Δ
unittests 79.31% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal merged commit 1ee119c into lancedb:main Aug 9, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants