Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop indices if all fragment ids are missing #2720

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

wjones127
Copy link
Contributor

Closes #2718

@github-actions github-actions bot added the bug Something isn't working label Aug 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.27%. Comparing base (e62055d) to head (3f7b9be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
- Coverage   79.31%   79.27%   -0.04%     
==========================================
  Files         227      227              
  Lines       66792    66804      +12     
  Branches    66792    66804      +12     
==========================================
- Hits        52973    52958      -15     
- Misses      10720    10737      +17     
- Partials     3099     3109      +10     
Flag Coverage Δ
unittests 79.27% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit 2f3573a into lancedb:main Aug 12, 2024
21 of 22 checks passed
@wjones127 wjones127 deleted the fix/remove-indices branch August 12, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting all rows does not remove all indices
3 participants