Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pushdown limit & offset into file reader if there is no filter #2747

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

westonpace
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Aug 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.61062% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.19%. Comparing base (987561f) to head (d9b6f8a).

Files Patch % Lines
rust/lance/src/io/exec/scan.rs 83.01% 4 Missing and 5 partials ⚠️
rust/lance/src/dataset/scanner.rs 91.17% 3 Missing ⚠️
rust/lance/src/datafusion/logical_plan.rs 75.00% 0 Missing and 1 partial ⚠️
rust/lance/src/dataset.rs 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
+ Coverage   79.17%   79.19%   +0.02%     
==========================================
  Files         227      227              
  Lines       67635    67733      +98     
  Branches    67635    67733      +98     
==========================================
+ Hits        53547    53640      +93     
+ Misses      10974    10973       -1     
- Partials     3114     3120       +6     
Flag Coverage Δ
unittests 79.19% <87.61%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit 18fbd7a into lancedb:main Aug 20, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants