Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert encoders to use data blocks #2817

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

westonpace
Copy link
Contributor

This is the last of the refactors needed to convert the encoders to working with data blocks.

Copy link
Contributor

@broccoliSpicy broccoliSpicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor suggestions, all others looks good to me.

@westonpace westonpace force-pushed the refactor/encoders-use-data-block branch from 1d35ff8 to 7c69ed2 Compare September 11, 2024 15:28
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.79487% with 220 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (c0e1f15) to head (cc64306).

Files with missing lines Patch % Lines
...-encoding/src/encodings/physical/block_compress.rs 0.00% 71 Missing ⚠️
rust/lance-encoding/src/encodings/physical/fsst.rs 0.00% 39 Missing ⚠️
rust/lance-encoding/src/data.rs 0.00% 28 Missing ⚠️
...ance-encoding/src/encodings/physical/dictionary.rs 82.75% 10 Missing and 10 partials ⚠️
rust/lance-encoding/src/format.rs 91.60% 9 Missing and 2 partials ⚠️
...ust/lance-encoding/src/encodings/physical/value.rs 60.86% 9 Missing ⚠️
rust/lance-encoding/src/encodings/physical.rs 11.11% 8 Missing ⚠️
...e-encoding/src/encodings/physical/packed_struct.rs 81.39% 3 Missing and 5 partials ⚠️
rust/lance-encoding/src/encoder.rs 75.00% 4 Missing ⚠️
...st/lance-encoding/src/encodings/physical/binary.rs 96.94% 1 Missing and 3 partials ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
- Coverage   78.12%   77.88%   -0.25%     
==========================================
  Files         229      231       +2     
  Lines       70492    70373     -119     
  Branches    70492    70373     -119     
==========================================
- Hits        55073    54807     -266     
- Misses      12305    12444     +139     
- Partials     3114     3122       +8     
Flag Coverage Δ
unittests 77.88% <71.79%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit f0fc411 into lancedb:main Sep 12, 2024
20 of 22 checks passed
westonpace added a commit that referenced this pull request Sep 18, 2024
The recent encodings refactor #2817
broke our ability to write fixed size list arrays of nullable values (we
could still handle nullable fixed size list arrays). This PR restores
the capability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants