Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vector column mismatch should not be a IO Error #2845

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

LuQQiu
Copy link
Collaborator

@LuQQiu LuQQiu commented Sep 8, 2024

Fixes #2843

@github-actions github-actions bot added the bug Something isn't working label Sep 8, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 78.04%. Comparing base (ef0953d) to head (cbda75e).

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 28.57% 19 Missing and 1 partial ⚠️
rust/lance-datafusion/src/logical_expr.rs 0.00% 1 Missing ⚠️
rust/lance/src/dataset/write.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2845   +/-   ##
=======================================
  Coverage   78.03%   78.04%           
=======================================
  Files         229      229           
  Lines       70299    70309   +10     
  Branches    70299    70309   +10     
=======================================
+ Hits        54859    54872   +13     
- Misses      12340    12343    +3     
+ Partials     3100     3094    -6     
Flag Coverage Δ
unittests 78.04% <26.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wjones127 wjones127 merged commit 0b2ed3c into lancedb:main Sep 9, 2024
20 of 22 checks passed
@LuQQiu LuQQiu deleted the fixError branch September 9, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: vector column mismatch should not be a IO Error
3 participants