Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a separate retry loop on object contents download #2874

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

westonpace
Copy link
Contributor

object_store has automatic retries. However, these retries only apply on the initial HTTP request (the sending and receiving of the headers. The download of the response body is not retried in the same way.

This download was previously covered by our outer retry loop but this had two problems:

  • It was not configurable
  • It was not obvious what the error was (the error would say "error decoding response body".

The download retry count is now configurable and the error message has been enhanced.

@github-actions github-actions bot added the enhancement New feature or request label Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 69.84127% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (ce1e61c) to head (38d61b8).

Files with missing lines Patch % Lines
rust/lance-io/src/object_store.rs 59.25% 9 Missing and 2 partials ⚠️
rust/lance-io/src/object_reader.rs 63.63% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2874   +/-   ##
=======================================
  Coverage   77.85%   77.86%           
=======================================
  Files         231      231           
  Lines       70382    70442   +60     
  Branches    70382    70442   +60     
=======================================
+ Hits        54799    54848   +49     
- Misses      12458    12462    +4     
- Partials     3125     3132    +7     
Flag Coverage Δ
unittests 77.86% <69.84%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting deja vu like I did this earlier, but maybe I am thinking about uploads.

@westonpace westonpace merged commit db1e39c into lancedb:main Sep 13, 2024
22 of 23 checks passed
@westonpace
Copy link
Contributor Author

Getting deja vu like I did this earlier, but maybe I am thinking about uploads.

😆 yes, we have MAX_CONN_RESET_RETRIES in the object writer for something very similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants