Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't filter on string column which has FTS index #2875

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

BubbleCal
Copy link
Contributor

@BubbleCal BubbleCal commented Sep 13, 2024

also fix BTree index isn't used if the column is with LargeUtf8 data type

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added bug Something isn't working python labels Sep 13, 2024
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 48.48485% with 34 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (ce1e61c) to head (ad3ee08).

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 0.00% 13 Missing ⚠️
rust/lance/src/index/scalar.rs 60.86% 6 Missing and 3 partials ⚠️
rust/lance/src/index.rs 69.23% 0 Missing and 8 partials ⚠️
rust/lance-datafusion/src/expr.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2875   +/-   ##
=======================================
  Coverage   77.85%   77.86%           
=======================================
  Files         231      231           
  Lines       70382    70413   +31     
  Branches    70382    70413   +31     
=======================================
+ Hits        54799    54826   +27     
- Misses      12458    12459    +1     
- Partials     3125     3128    +3     
Flag Coverage Δ
unittests 77.86% <48.48%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal marked this pull request as ready for review September 13, 2024 06:53
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks!

@BubbleCal BubbleCal merged commit 60797a6 into lancedb:main Sep 13, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants