-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix release versions #2897
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2897 +/- ##
==========================================
- Coverage 77.93% 77.92% -0.01%
==========================================
Files 231 231
Lines 70613 70613
Branches 70613 70613
==========================================
- Hits 55031 55028 -3
+ Misses 12462 12459 -3
- Partials 3120 3126 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes the Lance release error |
@@ -8,7 +8,7 @@ | |||
<parent> | |||
<groupId>com.lancedb</groupId> | |||
<artifactId>lance-parent</artifactId> | |||
<version>0.0.5</version> | |||
<version>0.18.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these automatically get updated as part of the release process? If not, we don't need to fix them in this PR but we should probably see if we can make that happen at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Lance, only patch version got updated during release but not minor version. And the bump version is bump from existing version. That's why need to set it correct for once.
Lancedb has more solid version setting approach during release
Solve the issue when publishing rust
Give the java pom correct versions