Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix release versions #2897

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix: fix release versions #2897

merged 3 commits into from
Sep 17, 2024

Conversation

LuQQiu
Copy link
Collaborator

@LuQQiu LuQQiu commented Sep 17, 2024

Solve the issue when publishing rust

- cargo package -v --no-verify                            ✔
error: all dependencies must have a version specified when packaging.
dependency `lance-encoding` does not specify a version
Note: The packaged dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.

Give the java pom correct versions

@github-actions github-actions bot added bug Something isn't working java labels Sep 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (78d90a9) to head (e77dcd0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2897      +/-   ##
==========================================
- Coverage   77.93%   77.92%   -0.01%     
==========================================
  Files         231      231              
  Lines       70613    70613              
  Branches    70613    70613              
==========================================
- Hits        55031    55028       -3     
+ Misses      12462    12459       -3     
- Partials     3120     3126       +6     
Flag Coverage Δ
unittests 77.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuQQiu
Copy link
Collaborator Author

LuQQiu commented Sep 17, 2024

Fixes the Lance release error

@@ -8,7 +8,7 @@
<parent>
<groupId>com.lancedb</groupId>
<artifactId>lance-parent</artifactId>
<version>0.0.5</version>
<version>0.18.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these automatically get updated as part of the release process? If not, we don't need to fix them in this PR but we should probably see if we can make that happen at some point.

Copy link
Collaborator Author

@LuQQiu LuQQiu Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Lance, only patch version got updated during release but not minor version. And the bump version is bump from existing version. That's why need to set it correct for once.
Lancedb has more solid version setting approach during release

@LuQQiu LuQQiu merged commit 9ea8d5a into lancedb:main Sep 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants