Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support negative values in SQL array literals #2925

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

wjones127
Copy link
Contributor

Fixes #2695

@github-actions github-actions bot added the bug Something isn't working label Sep 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.21739% with 16 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (f48e970) to head (4c0a92a).

Files with missing lines Patch % Lines
rust/lance-datafusion/src/planner.rs 65.21% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2925      +/-   ##
==========================================
+ Coverage   77.81%   77.83%   +0.01%     
==========================================
  Files         231      231              
  Lines       70259    70291      +32     
  Branches    70259    70291      +32     
==========================================
+ Hits        54672    54708      +36     
- Misses      12693    12698       +5     
+ Partials     2894     2885       -9     
Flag Coverage Δ
unittests 77.83% <65.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit 4f91ff1 into lancedb:main Sep 24, 2024
21 of 22 checks passed
@wjones127 wjones127 deleted the fix/negative-values-in-arrays branch September 25, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update list if there are negative values
3 participants