fix: list_indices never updated after first call #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
westonpace
approved these changes
Sep 26, 2024
python/python/lance/dataset.py
Outdated
| num_indices_to_merge: int, default 1 | ||
| The number of indices to merge. | ||
| If set to 0, new delta index will be created. | ||
| indexe_names: List[str], default None |
There was a problem hiding this comment.
Suggested change
| indexe_names: List[str], default None | |
| index_names: List[str], default None |
Comment on lines
+1031
to
+1037
| dataset | ||
| .optimize_indices(&OptimizeOptions { | ||
| num_indices_to_merge: 0, // Just create index for delta | ||
| index_names: Some(vec![]), // Optimize nothing | ||
| }) | ||
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
Do you want to add a test case where index_names is set but non-empty?
There was a problem hiding this comment.
good point, added tests to cover it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2936 +/- ##
==========================================
+ Coverage 77.76% 77.77% +0.01%
==========================================
Files 231 231
Lines 70487 70562 +75
Branches 70487 70562 +75
==========================================
+ Hits 54817 54883 +66
+ Misses 12771 12769 -2
- Partials 2899 2910 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ankitvij-db
pushed a commit
to ankitvij-db/lance
that referenced
this pull request
Sep 26, 2024
lance in rust would cache the index metadata so no need to cache it in python. - also added an option to control which indices to optimize - also added tests for optimize_indices --------- Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lance in rust would cache the index metadata so no need to cache it in python.