Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include the list item field schema #2950

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

westonpace
Copy link
Contributor

closes #2947

@github-actions github-actions bot added bug Something isn't working python labels Sep 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (75aa2c2) to head (17a6690).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-encoding/src/encodings/logical/list.rs 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
+ Coverage   78.52%   78.99%   +0.46%     
==========================================
  Files         232      234       +2     
  Lines       70911    72810    +1899     
  Branches    70911    72810    +1899     
==========================================
+ Hits        55681    57514    +1833     
- Misses      12283    12330      +47     
- Partials     2947     2966      +19     
Flag Coverage Δ
unittests 78.99% <94.11%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit a7c6bac into lancedb:main Oct 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataset with nested field metadata could be written but cannot be read
3 participants