Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't always include first doc #2957

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

wjones127
Copy link
Contributor

Fixes #2930

@github-actions github-actions bot added bug Something isn't working python labels Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (396b4d1) to head (cd16d12).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-index/src/scalar/inverted/wand.rs 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2957   +/-   ##
=======================================
  Coverage   78.99%   78.99%           
=======================================
  Files         234      234           
  Lines       72829    72833    +4     
  Branches    72829    72833    +4     
=======================================
+ Hits        57530    57535    +5     
+ Misses      12329    12328    -1     
  Partials     2970     2970           
Flag Coverage Δ
unittests 78.99% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Thanks for fixing :)

@wjones127 wjones127 merged commit 4f8bd6d into lancedb:main Sep 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTS seems to always consider the first row even if it should be masked by prefilter
3 participants